dragboard: Compat w backswipe on newer firmwares #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
thyttan
commented
Jul 31, 2023
| } | ||
| }; | ||
|
|
||
| let catchSwipe = (_,__)=>{ |
There was a problem hiding this comment.
@gfwilliams, mostly out of curiosity, would it be smarter to just do let catchSwipe = ()=>( here, without the arguments? If I get to add this to other keyboards I can do whatever is better also.
There was a problem hiding this comment.
Yes, if you're not using the arguments it's better not to add them - it's not much but each argument you don't define saves you one variable's worth of memory
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #2910.
This should work, does in the testing I've done on fw 2v18.115. Also shouldn't break on older firmwares if I did things right (not tested).