Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mylocation: Add option to set location from waypoint #2839

Merged
merged 2 commits into from
Jun 26, 2023
Merged

mylocation: Add option to set location from waypoint #2839

merged 2 commits into from
Jun 26, 2023

Conversation

nxdefiant
Copy link
Contributor

@nxdefiant nxdefiant commented Jun 25, 2023 •
edited
Loading

Notify @hughbarney

Added dependency for waypoint. I could change that to "only show menu if waypoint is installed".

@gfwilliams
Copy link
Member

Thanks! Do you think you could change it to 'only show menu if waypoints installed'?

It's just that we have a few apps that depend on mylocation to get a location, and they don't really need waypoint installed as well - it's a nice feature if they have it though :)

@nxdefiant
Copy link
Contributor Author

will do

@nxdefiant nxdefiant marked this pull request as draft June 26, 2023 11:58
@nxdefiant nxdefiant marked this pull request as ready for review June 26, 2023 12:10
@nxdefiant
Copy link
Contributor Author

done.

@gfwilliams
Copy link
Member

Thanks!

@gfwilliams gfwilliams merged commit 7dfabf9 into espruino:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxdefiant @gfwilliams