Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Swatch Internet Time widget (widswatchbeats) #2835

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

npbreland
Copy link
Contributor

Just got my Bangle a few weeks ago and I wanted to try contributing a small widget. This widget shows the current Swatch Internet Time in the top left. Please let me know then if there is anything I should change!

@gfwilliams
Copy link
Member

Looks great, thanks! Only thing I'd say is you don't need the widget-icon.js/widswatchbeats.img - because it's a widget it doesn't appear in the launcher, so an icon won't ever be displayed anywhere.

Please could you take that out? Just remove widget-icon.js and the associated line in metadata.json? And I'll merge

@npbreland
Copy link
Contributor Author

Thanks for having a look! That makes sense, since it's a widget. I just removed the image line.

@gfwilliams
Copy link
Member

Thanks! Merging now :)

@gfwilliams gfwilliams merged commit be5fcdd into espruino:master Jun 23, 2023
1 check passed
@npbreland
Copy link
Contributor Author

npbreland commented Jun 23, 2023

Great! Thanks for deleting widget-icon.js for me -- forgot that part.

@gfwilliams
Copy link
Member

No problem - thanks for contributing!

It's on the dev app loader now, but won't go live on banglejs.com/apps until next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants