Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if no timebase is set #749

Closed
bugadani opened this issue Aug 23, 2023 · 1 comment
Closed

Fail if no timebase is set #749

bugadani opened this issue Aug 23, 2023 · 1 comment

Comments

@bugadani
Copy link
Contributor

Last few days I had various silent breakages because embassy-time was 1) removed 2) pinned to a specific version. In both cases, the version mismatch meant that no embassy-time-* feature was active, and embassy-time was initialized with the default 1MHz timer frequency.

I am not sure what we can do here, but I would like a solution that doesn't compile (or, at least warns) if esp-hal would fail to apply a timer frequency as it's an unfortunately difficult thing to debug.

@bugadani
Copy link
Contributor Author

Maybe we could consider this a non-issue for now, now that the crate uses embassy-time 0.1.3.

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant