Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve genesis emulation #88

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

finger563
Copy link
Contributor

Description

  • Update genesis sound emulation to disable sn76489 emulation
  • Update genesis emulation to skip 1 frame when muted (buttery smooth) but 6 frames when audio is playing
  • Update genesis emulation VDP_CYCLES_PER_FRAME to actually be correct for better emulation
  • Update how audio emulation accuracy configuration is set (CMakeLists.txt)
  • Don't run z80 emulation if sound is disabled.
  • Set main task priority to 20

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 self-assigned this Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

✅Static analysis result - no issues found! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant