This document is a declaration of software quality for the rcl_action package, based on the guidelines in REP-2004.
The package rcl_action claims to be in the Quality Level 1 category when it is used with a Quality Level 1 middleware.
Below are the rationales, notes, and caveats for this claim, organized by each requirement listed in the Package Quality Categories in REP-2004.
rcl_action uses semver according to the recommendation for ROS Core packages in the ROS 2 Developer Guide.
rcl_action is at a stable version, i.e. >= 1.0.0.
The current version can be found in its package.xml, and its change history can be found in its CHANGELOG.
All symbols in the installed headers are considered part of the public API.
All installed headers are in the include directory of the package, headers in any other folders are not installed and considered private.
rcl_action will not break public API within a released ROS distribution, i.e. no major releases once the ROS distribution is released.
rcl_action contains C and C++ code and therefore must be concerned with ABI stability, and will maintain ABI stability within a ROS distribution.
rcl_action follows the recommended guidelines for ROS Core packages in the ROS 2 Developer Guide.
This package requires that all changes occur through a pull request.
This package uses DCO as its confirmation of contributor origin policy. More information can be found in CONTRIBUTING.
Following the recommended guidelines for ROS Core packages, all pull requests must have at least 1 peer review.
All pull requests must pass CI on all tier 1 platforms.
All pull requests must resolve related documentation changes before merging.
rcl_action has feature documentation actions in ROS 2.
It is hosted.
Most of rcl_action has embedded API documentation and it is hosted.
The license for rcl_action is Apache 2.0, and a summary is in each source file, the type is declared in the package.xml manifest file, and a full copy of the license is in the LICENSE file.
There is an automated test which runs a linter that ensures each file has a license statement.
The most recent test results can be found here.
The copyright holders each provide a statement of copyright in each source code file in rcl_action.
There is an automated test which runs a linter that ensures each file has at least one copyright statement.
The results of the test can be found here.
rcl_action has feature tests, which test for proper node state transitions.
The tests are located in the test subdirectory.
New features are required to have tests before being added.
Currently nightly test results can be seen here:
Each part of the public API has tests, and new additions or changes to the public API require tests before being added. The tests aim to cover both typical usage and corner cases, but are quantified by contributing to code coverage.
rcl_action follows the recommendations for ROS Core packages in the ROS 2 Developer Guide, and opts to use line coverage instead of branch coverage.
This includes:
- tracking and reporting line coverage statistics
- no lines are manually skipped in coverage calculations
Changes are required to make a best effort to keep or increase coverage before being accepted, but decreases are allowed if properly justified and accepted by reviewers.
Current coverage statistics can be viewed here. A description of how coverage statistics are calculated is summarized in this page "ROS 2 Onboarding Guide".
rcl_action follows the recommendations for performance testing of C code in the ROS 2 Developer Guide, and opts to do performance analysis on each release rather than each change.
System level performance benchmarks that cover features of rcl_action can be found at:
Changes that introduce regressions in performance must be adequately justified in order to be accepted and merged.
rcl_action uses and passes all the standard linters and static analysis tools for a C package as described in the ROS 2 Developer Guide.
Results of the nightly linter tests can be found here.
Below are evaluations of each of rcl_action's run-time and build-time dependencies that have been determined to influence the quality.
It has several "buildtool" dependencies, which do not affect the resulting quality of the package, because they do not contribute to the public library API. It also has several test dependencies, which do not affect the resulting quality of the package, because they are only used to build and run the test code.
rcl_action has the following runtime ROS dependencies:
action_msgs provides messages and services for ROS 2 actions.
It is Quality Level 1, see its Quality Declaration document.
rcl is the ROS 2 client library in C.
It is Quality Level 1, see its Quality Declaration document.
rcutils provides commonly used functionality in C.
It is Quality Level 1, see its Quality Declaration document.
rmw is the ROS 2 middleware library.
It is Quality Level 1, see its Quality Declaration document.
rosidl_runtime_c provides runtime functionality for rosidl message and service interfaces.
It is Quality Level 1, see its Quality Declaration document.
rcl_action does not have any runtime non-ROS dependencies.
rcl_action supports all of the tier 1 platforms as described in REP-2000, and tests each change against all of them.
Currently nightly results can be seen here:
This package conforms to the Vulnerability Disclosure Policy in REP-2006.