Remove connection-specific headers from HTTP/2 message. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinKuzma
requested changes
Aug 12, 2024
danielkraic
reviewed
Aug 13, 2024
|
|
||
| return metadata.NewOutgoingContext(request.Context(), grpcMetadata) | ||
| } | ||
|
|
||
| func SetRESTHeaders(headers http.Header, gRPCheader metadata.MD, gRPCTrailer metadata.MD) { | ||
| func setHeader(headers http.Header, protoMajor int, name string, values []string) { |
There was a problem hiding this comment.
Optional: Move this function to the bottom of the file.
It is not required in Go to define a function before this function is used. Best practice for more readable code is to define exported functions first and then un-exported functions. Files are meant to be read from top to bottom, not the opposite way. Therefore the more important functions (exproted) should be defined before less important functions.
MartinKuzma
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.