Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize API/CLI/SDK error messages #881

Open
purehyperbole opened this issue Feb 19, 2018 · 0 comments
Open

Standardize API/CLI/SDK error messages #881

purehyperbole opened this issue Feb 19, 2018 · 0 comments
Labels

Comments

@purehyperbole
Copy link
Member

purehyperbole commented Feb 19, 2018

Preamble

Idea: <to be assigned>
Title: Standardize CLI/SDK error messages
Status: Draft
Created: 2018-02-21

Summary

There are some inconsistencies with the wording, grammar and punctuation returned to the user. We should standardise these errors.

Product Overview

Product Description

Actually all messages directly returned by the CLI are stored on a translation file should be easy to go through them and standarize them.

On the other side there are some error messages directly coming from the api, in this case we have 2 options.

  • (1) Also standarize the error messages on the api.
  • (2) Forcing api responses to always include a more explicit error id, so the CLI can map it against local errors.

Imho we should implement both, so we standarize the api in case any 3rd party client is using it, but we gain control over the CLI output.

Requirements & Dependancies

We should divide this feature on different iterations:

Iteration 1 : Define standard

We should agree on a specification for all error messages. This document must live on github.com/ernestio/ernest/docs and should describe exactly how error messages should look like. Additionally it should be referenced on the api-gateway and ernest-cli READMEs.

Iteration 2 : The list

A list of possible errors, at the api and cli level, must be created so necessary issues can be created. And create necessary issues.

Each issue will have to fix api or cli, and the relative problems on the ernestio/ernest integration tests

Iteration 3 : Error codes

Both api-gateway and ernest-cli must be able to work together based on predefined error codes. As this can be threated as a feature itself it will be managed on #880

@adriacidre adriacidre changed the title Standardize CLI/SDK error messages Standardize API/CLI/SDK error messages Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants