Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate std::format support #2384

Open
battlmonstr opened this issue Sep 30, 2024 · 0 comments
Open

investigate std::format support #2384

battlmonstr opened this issue Sep 30, 2024 · 0 comments
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)

Comments

@battlmonstr
Copy link
Contributor

battlmonstr commented Sep 30, 2024 •
edited
Loading

std::format is supported on clang 17+, but we're on 16.

As a part of this task:

  1. Investigate what's needed to upgrade to 17.
  2. Test that it works on all our compilers.
  3. Test that it works on our silkworm-go release CI.

Implementation note:
clang debian packages can be installed from apt.llvm.org, and we already support it (see compiler_install.sh and llvm.sh), so this could be a matter of bumping the min version.
@battlmonstr battlmonstr added the maintenance Some maintenance work (fix, refactor, rename, test...) label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@battlmonstr