Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce netgo (fix issues #12570 and #12556) #12597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

antonis19
Copy link
Member

Reintroducing netgo into the builds to fix the following issues:
#12556
#12570

netgo was removed in this PR:
#7421

but didn't seem to fix that issue.

@lystopad
Copy link
Member

lystopad commented Nov 4, 2024

@antonis19 , hi
please, consider also add this tag to the following pipeline as well:
https://github.com/erigontech/erigon/blob/main/.github/workflows/ci-cd-main-branch-docker-images.yml

Copy link
Collaborator

@AskAlexSharov AskAlexSharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my concern is: we don't know fail-reason.
it's ok for me to add netgo as a temporary workaround (we don't know if it's good workaround) - and merge. But after merge we must continue work on this issue - with high-prio until we find root cause and right fix.
compilation from source works on user's machines: go run ./cmd/erigon. Means: we will need fix for cross-compilation pipeline - to work with default golang's build tags (without netgo). also to add test-case on CI.

Possible steps to debug:

  • strace CMD.... 2>&1 | grep -E '^open(at)?\(.*\.so' - or another tool to track sharedLibs/syscalls
  • erigon --no-downloader --txpool.disable --http=false - or create sub-command which can reproduce issue without "startup and waiting for unknown time" (then we can add this sub-command to CI).
  • I feel issue related to DNS discovery and static linking

cc: @antonis19 @lystopad @mh0lt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants