Pick up latest snapshots #11455
Merged
Pick up latest snapshots #11455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested review from
somnathb1,
Giulio2002,
AskAlexSharov and
michelemodolo
michelemodolo
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
The PR itself looks fine to me, yet... the included PRs are the ones which enabled Ottersync and Ottersync was already successfully tested on all chains. How was that possible?
Perhaps erigon is already using a direct read from erigon-snapshot/any-chain.toml without any static inclusion (which is the purpose of this #11455 PR)? @Giulio2002 @AskAlexSharov
somnathb1
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick up erigontech/erigon-snapshot#236, erigontech/erigon-snapshot#239, erigontech/erigon-snapshot#238, erigontech/erigon-snapshot#240, erigontech/erigon-snapshot#241, erigontech/erigon-snapshot#242, erigontech/erigon-snapshot#243, erigontech/erigon-snapshot#244, and erigontech/erigon-snapshot#245.