Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore headers by default? #21

Open
ericclemmons opened this issue Apr 23, 2019 · 1 comment
Open

Ignore headers by default? #21

ericclemmons opened this issue Apr 23, 2019 · 1 comment

Comments

@ericclemmons
Copy link
Owner

There seems to be more surprises by how hashing operates, considering headers.

So, either there could be a hash option for customizing...

Or, normalize can choose to return the normalized object (instead of mutating), where returning undefined will keep normal normalization.

(I still think that Polly.js does a good job of hashing headers with matchRequsestsBy: https://netflix.github.io/pollyjs/#/configuration?id=defaults)

@ericclemmons
Copy link
Owner Author

In practice, I've found that the best place to pay attention to headers is within the tests themselves.

When a request is made, I think it's better to have something like x-recorder-headers: ["x-test-id", "x-custom-header"] to specify what you want to keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant