Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record identified calls when one is missing #19

Open
ericclemmons opened this issue Apr 22, 2019 · 0 comments
Open

Record identified calls when one is missing #19

ericclemmons opened this issue Apr 22, 2019 · 0 comments

Comments

@ericclemmons
Copy link
Owner

Here's the scenario:

  1. Today:
  2. Get access token (recorded).
  3. Get data with access token (recorded).
  4. Tomorrow:
  5. Get access token (replayed, same user).
  6. Get data with access token fails because of 401.

The problem here is that we replay a fixture for that expired access token, but the new data calls need a valid token.

A couple ways to remedy this:

  • The easiest way is that the normalizer should not delete any properties (e.g. sig, or possibly a date) that would replay old tokens for new requests.
  • The harder way is to re-record all previously replayed requests that share that same identity. (However, what will this mean for previously-recorded responses that depend on those headers?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant