Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Request] /block/ **endpoints** #2108

Open
mgpai22 opened this issue Feb 2, 2024 · 6 comments
Open

[API Request] /block/ **endpoints** #2108

mgpai22 opened this issue Feb 2, 2024 · 6 comments

Comments

@mgpai22
Copy link
Contributor

mgpai22 commented Feb 2, 2024

When headers information only is returned it would be useful to also return transaction count.

This is needed because currently, if I want transaction count I must load the full block which returns all transaction information. This may not be an issue for one block, however, when requesting several full blocks in one request, the data really adds up. It becomes unmanageable for web clients.

@mgpai22
Copy link
Contributor Author

mgpai22 commented Feb 2, 2024

Miner contract address being returned for header information would be useful as well. You can either determine it by getting full block information and parsing the coinbase transaction, or it can be compiled using the pk found in the header response.

@mgpai22
Copy link
Contributor Author

mgpai22 commented Feb 3, 2024

size on explorer vs node does not seem to match

@kushti
Copy link
Member

kushti commented Feb 5, 2024

Size on the explorer looks weird , max short value just.

I guess, you are requesting a new method which will return transactions count (miner address) by header id ? Not sure this information is needed for all the header endpoint users.

@mgpai22
Copy link
Contributor Author

mgpai22 commented Feb 5, 2024

I was hoping it would be returned with all current header info endpoint rather than a new dedicated endpoint for my request

@kushti
Copy link
Member

kushti commented Feb 5, 2024

I was hoping it would be returned with all current header info endpoint rather than a new dedicated endpoint for my request

Why "/header" request should suddenly start providing auxiliary information in addition to header? I think introducing new request is more clear

@mgpai22
Copy link
Contributor Author

mgpai22 commented Feb 7, 2024

@kushti the problem with a new request is that it is only one specific endpoint. I ask that the auxiliary information is added to the BlockHeader schema itself as it allows all header related endpoint to have the info such as /blocks, /blocks/at, /blocks/chainSlice, etc.

It is difficult to use the node as a replacement to the explorer otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants