-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-0045 Redistribution contracts for Storage Rent Fees #93
Open
The-Huginn
wants to merge
3
commits into
ergoplatform:master
Choose a base branch
from
The-Huginn:eip-45
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
requested changes
Mar 29, 2023
eip-0045.md
Outdated
|
||
The long-term security of the Ergo protocol should be prioritized and should try to avoid any potential vulnerabilities. One such can occur from claiming storage fees from boxes, that are subject to such claims. Resulting from fact if block rewards are no longer present, or negligible, compared to the claim from storage fees, mining a block claiming multiple storage fees might be subject to so called **undercutting attack** introduced in [[1]](#references). This happens when certain block has much higher reward compared to other blocks and therefore miners might be tempted to remine it to claim the reward for themselves instead of the original miner. | ||
|
||
To circumvent such problem we introduce a Smart Contract, where the storage fees should be send and then this Smart Contract will redistribute the rewards across a span of selected blocks (for example 720 blocks, i.e. 1 day). Providing a reward from claiming storage fees to multiple blocks not only the one it was claimed in. A ratio of M to C can be used, where a miner can claim M of the storage fees and has to send C ratio to the Smart Contract. However we argue the ratio should be much smaller in favor of M as claiming storage fee is not very predictable and repeatable as claiming transaction fees, refer to [section](#previous-considerations). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
To circumvent such problem we introduce a Smart Contract, where the storage fees should be send and then this Smart Contract will redistribute the rewards across a span of selected blocks (for example 720 blocks, i.e. 1 day). Providing a reward from claiming storage fees to multiple blocks not only the one it was claimed in. A ratio of M to C can be used, where a miner can claim M of the storage fees and has to send C ratio to the Smart Contract. However we argue the ratio should be much smaller in favor of M as claiming storage fee is not very predictable and repeatable as claiming transaction fees, refer to [section](#previous-considerations). | |
To circumvent such problem we introduce a Smart Contract, where the storage fees should be sent and then this Smart Contract will redistribute the rewards across a span of selected blocks (for example 720 blocks, i.e. 1 day). Providing a reward from claiming storage fees to multiple blocks not only the one it was claimed in. A ratio of M to C can be used, where a miner can claim M of the storage fees and has to send C ratio to the Smart Contract. However we argue the ratio should be much smaller in favor of M as claiming storage fee is not very predictable and repeatable as claiming transaction fees, refer to [section](#previous-considerations). |
) | ||
) | ||
) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@The-Huginn, please explictily describe the box which should be protected by this contract and if it has additional registers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please feel free to review & discuss.