Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-0023 Oracle pool 2.0 #41

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

EIP-0023 Oracle pool 2.0 #41

wants to merge 47 commits into from

Conversation

scalahub
Copy link
Contributor

@scalahub scalahub commented Sep 7, 2021

Main features in v2.0

  1. Single pool address (only one type of box). This version of the pool will have only one address, the pool address.
  2. Data-point boxes will be considered as inputs rather than data-inputs. These inputs will be spent, and a copy of the box with the reward will be created.
  3. Reward in tokens not Ergs. The posting reward will be in the form of tokens, which can be redeemed separately.
  4. Reward accumulated in data point boxes to prevent dust. We will not be creating a new box for rewarding each posting. Instead, the rewards will be accumulated in data-point boxes.
  5. When creating a data-point box, the pool box is not needed as data input. Creating a data-point will be decoupled from the pool, and will not require the bool box as data-input.
  6. Update mechanism as before. We will have the same update mechanism as in v1.0
  7. Transferable participant tokens. Participant tokens are free to be transferred between public keys
  8. Longer epoch period (1 hour or 30 blocks).
  9. No separate funding box. The pool box emits only reward tokens and won't be handing out Ergs. Thus, there won't be a separate funding process required.
  10. Reward mechanism separate from pool. The process of redeeming the reward tokens is not part of the protocol.

@scalahub
Copy link
Contributor Author

https://github.com/ergoplatform/eips/blob/eip23/eip-0023.md#reward-mechanism

Document mentions "We also give a sample token exchange contract", which seems to be missing. Either add the contract or remove the sentence

eip-0023.md Outdated Show resolved Hide resolved
eip-0023.md Outdated Show resolved Hide resolved
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
To be completely sure, I'd wait with PR merging until we implement voting and update operations.

eip-0023.md Outdated Show resolved Hide resolved
eip-0023.md Outdated Show resolved Hide resolved
@greenhat
Copy link
Member

@scalahub Could you please merge #78 into this PR?

eip-0023.md Outdated Show resolved Hide resolved
eip-0023/eip-0023.md Outdated Show resolved Hide resolved
Co-authored-by: Denys Zadorozhnyi <[email protected]>
…-tokens-check

[EIP-0023] In update contract check reward tokens are either preserved or voted by ballot boxes
EIP-0023. Let ballot token owner (R4 in ballot box) always spend the ballot box
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just added the fix to the oracle token transfer process. It's already implemented in the code.

eip-0023/eip-0023.md Outdated Show resolved Hide resolved
Co-authored-by: Denys Zadorozhnyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants