-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-0023 Oracle pool 2.0 #41
base: master
Are you sure you want to change the base?
Conversation
22 is already taken by auction contracts
https://github.com/ergoplatform/eips/blob/eip23/eip-0023.md#reward-mechanism Document mentions "We also give a sample token exchange contract", which seems to be missing. Either add the contract or remove the sentence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
To be completely sure, I'd wait with PR merging until we implement voting and update operations.
Co-authored-by: Denys Zadorozhnyi <[email protected]>
Co-authored-by: Denys Zadorozhnyi <[email protected]>
EIP23 separate contract files
Rewrite confusing text in description
Co-authored-by: Denys Zadorozhnyi <[email protected]>
…by ballot boxes; make reward token id and amount optional in ballot box;
We have not given a sample token exchange contract so we should remove the text.
…-tokens-check [EIP-0023] In update contract check reward tokens are either preserved or voted by ballot boxes
after changes introduced in 3bd226b hash is calculated in https://scastie.scala-lang.org/W1KaudPGT2WBmJfHDsjlaw
EIP-0023. Let ballot token owner (R4 in ballot box) always spend the ballot box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just added the fix to the oracle token transfer process. It's already implemented in the code.
Co-authored-by: Denys Zadorozhnyi <[email protected]>
Main features in v2.0