Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions provider SPI #166

Merged
merged 5 commits into from
Jul 30, 2024
Merged

functions provider SPI #166

merged 5 commits into from
Jul 30, 2024

Conversation

erdos
Copy link
Owner

@erdos erdos commented Jul 29, 2024

Reimplements #138

and resolves conflicts with code changed in the meanwhile. We aim to keep the code simpler this time:

  • no function priorities - to keep code simple. We do not allow overriding of functions (by same name) but instead just throw an exception when function with same name already exists.
  • small footprint in code diff (ideally below 100 LOC)
  • automatic configuration generation (in META-INF)

Scenarios to manually test:

  • java functions available in clj unit tests
  • available in standalone mode (uberjar)
  • available when stencil is used as a library (jar)
  • available in standalone mode compiled with GraalVM native-image
  • available when ran as docker service
  • available when ran in native docker service

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (0816a6c) to head (70d0cab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files          30       30           
  Lines        2076     2076           
  Branches       92       92           
=======================================
  Hits         1947     1947           
  Misses         37       37           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erdos erdos mentioned this pull request Jul 29, 2024
@erdos erdos marked this pull request as ready for review July 29, 2024 19:15
@erdos erdos merged commit ad00799 into master Jul 30, 2024
6 checks passed
@erdos erdos deleted the functions-provider-spi branch July 30, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant