Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pptx rendering #161

Merged
merged 12 commits into from
May 21, 2024
Merged

fix: pptx rendering #161

merged 12 commits into from
May 21, 2024

Conversation

erdos
Copy link
Owner

@erdos erdos commented Apr 22, 2024

Investigating #160

Issue seems to be that data model in model.clj is too rigid, cannot properly represent pptx files. The internal references are missing from the generated files.

TODO:

  • Make sure both slide, slideMaster, slideLayout files are present in the generated pptx file.
  • Ensure that there are no dangling references that are included in the template.
  • Guarantee that the XML namespaces are consistent in the internal xml files by fixing the alias names.
  • Unit test coverage
  • Visual integration test to prevent regression
  • Test manually with LibreOffice
  • Test manually with MS Office (365?)

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.39%. Comparing base (65d7d1b) to head (92f781f).

Files Patch % Lines
src/stencil/model.clj 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   93.24%   93.39%   +0.14%     
==========================================
  Files          31       31              
  Lines        2072     2088      +16     
  Branches      102      100       -2     
==========================================
+ Hits         1932     1950      +18     
  Misses         38       38              
+ Partials      102      100       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erdos erdos marked this pull request as ready for review May 21, 2024 19:34
@erdos erdos merged commit 2cd6406 into master May 21, 2024
6 checks passed
@erdos erdos deleted the fix-pptx branch May 21, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant