Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): eci fluent-bit sidecar log collect error #6464

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

iutx
Copy link
Member

@iutx iutx commented Nov 1, 2024

What this PR does / why we need it:

fix eci fluent-bit sidecar log collect error.

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English fix eci fluent-bit sidecar log collect error
🇨🇳 中文 修复 eci fluent-bit sidecar 容器采集失败的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added bugfix orchestrator workload management labels Nov 1, 2024
@erda-bot erda-bot requested a review from sfwn November 1, 2024 06:25
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (8dc57ee) to head (1b458f1).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6464   +/-   ##
=======================================
  Coverage   15.14%   15.15%           
=======================================
  Files        3674     3674           
  Lines      376847   376851    +4     
=======================================
+ Hits        57085    57093    +8     
+ Misses     314303   314295    -8     
- Partials     5459     5463    +4     
Flag Coverage Δ
by-github-actions 15.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...trator/scheduler/executor/plugins/k8s/lifecycle.go 100.00% <100.00%> (+46.15%) ⬆️

... and 4 files with indirect coverage changes

@sfwn
Copy link
Member

sfwn commented Nov 1, 2024

/approve

@erda-bot erda-bot merged commit 3e3030f into erda-project:master Nov 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants