Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eventbox): print human-readable error log #6460

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Oct 29, 2024

What this PR does / why we need it:

print human-readable error log

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English polish(eventbox): print human-readable error log
🇨🇳 中文 优化(eventbox): 打印人类可读的错误日志

@erda-bot erda-bot requested a review from iutx October 29, 2024 07:59
@sfwn sfwn changed the title polish(eventbox): print human-readable error log chore(eventbox): print human-readable error log Oct 29, 2024
@luobily
Copy link
Member

luobily commented Oct 29, 2024

/approve

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (9aaa584) to head (4114941).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/messenger/eventbox/types/types.go 0.00% 3 Missing ⚠️
...essenger/eventbox/dispatcher/filters/lastfilter.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6460   +/-   ##
=======================================
  Coverage   15.14%   15.14%           
=======================================
  Files        3674     3674           
  Lines      376844   376847    +3     
=======================================
+ Hits        57076    57089   +13     
+ Misses     314307   314296   -11     
- Partials     5461     5462    +1     
Flag Coverage Δ
by-github-actions 15.14% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...essenger/eventbox/dispatcher/filters/lastfilter.go 0.00% <0.00%> (ø)
internal/core/messenger/eventbox/types/types.go 37.50% <0.00%> (-5.36%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfwn sfwn merged commit eb1bfd6 into erda-project:master Oct 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants