Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add erc7484 to msaadvanced #26

Merged
merged 5 commits into from
Jun 22, 2024
Merged

feat: add erc7484 to msaadvanced #26

merged 5 commits into from
Jun 22, 2024

Conversation

kopy-kat
Copy link
Contributor

@kopy-kat kopy-kat commented Apr 9, 2024

No description provided.

@livingrockrises
Copy link
Contributor

alternate way would also be to have this .check happen inside a hook

@kopy-kat
Copy link
Contributor Author

kopy-kat commented May 2, 2024

@kopy-kat
Copy link
Contributor Author

kopy-kat commented May 2, 2024

one thing that I thought could be useful is demonstrate more advanced integrations in msa advanced to highlight some additional features that are outside of 7579 but accounts could use (eg hooks, 7484, policy/signers) - wdyt

@livingrockrises
Copy link
Contributor

one thing that I thought could be useful is demonstrate more advanced integrations in msa advanced to highlight some additional features that are outside of 7579 but accounts could use (eg hooks, 7484, policy/signers) - wdyt

yes I do want to add tests in 7579 repo (reference / biconomy v3 -calling this 'Nexus' now) using module-kit
using some real 'useful executor' and real hooks which cover

  • installation and 7484
  • executor limits
    etc
    can chat more

@kopy-kat kopy-kat merged commit 4f27201 into main Jun 22, 2024
2 of 3 checks passed
@kopy-kat kopy-kat deleted the feature/add-erc7484 branch June 22, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants