From 4d77c90e3f8cafa0b1ed746b8b0748b5eed9a275 Mon Sep 17 00:00:00 2001 From: Timur Badretdinov Date: Fri, 23 Feb 2024 19:33:25 +0000 Subject: [PATCH 1/4] fix: typo --- src/MSABasic.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MSABasic.sol b/src/MSABasic.sol index 1129d61..556a1a5 100644 --- a/src/MSABasic.sol +++ b/src/MSABasic.sol @@ -145,7 +145,7 @@ contract MSABasic is IMSA, ExecutionHelper, ModuleManager { address validator; // @notice validator encodig in nonce is just an example! // @notice this is not part of the standard! - // Account Vendors may choose any other way to impolement validator selection + // Account Vendors may choose any other way to implement validator selection uint256 nonce = userOp.nonce; assembly { validator := shr(96, nonce) From f0927d6dfa2aa757ee9373b93bd898db96ecdf5f Mon Sep 17 00:00:00 2001 From: Timur Badretdinov Date: Fri, 23 Feb 2024 19:42:07 +0000 Subject: [PATCH 2/4] fix: typos --- src/MSABasic.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/MSABasic.sol b/src/MSABasic.sol index 556a1a5..6fd37a2 100644 --- a/src/MSABasic.sol +++ b/src/MSABasic.sol @@ -143,7 +143,7 @@ contract MSABasic is IMSA, ExecutionHelper, ModuleManager { returns (uint256 validSignature) { address validator; - // @notice validator encodig in nonce is just an example! + // @notice validator encoding in nonce is just an example! // @notice this is not part of the standard! // Account Vendors may choose any other way to implement validator selection uint256 nonce = userOp.nonce; @@ -151,7 +151,7 @@ contract MSABasic is IMSA, ExecutionHelper, ModuleManager { validator := shr(96, nonce) } - // check if validator is enabled. If terminate the validation phase. + // check if validator is enabled. If not terminate the validation phase. if (!_isValidatorInstalled(validator)) return VALIDATION_FAILED; // bubble up the return value of the validator module From bd2384fcd603fc6531ff8d4b0c6c9024ab019437 Mon Sep 17 00:00:00 2001 From: Timur Badretdinov Date: Fri, 23 Feb 2024 20:20:28 +0000 Subject: [PATCH 3/4] Update MSAAdvanced.sol --- src/MSAAdvanced.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/MSAAdvanced.sol b/src/MSAAdvanced.sol index 566b74b..f66d144 100644 --- a/src/MSAAdvanced.sol +++ b/src/MSAAdvanced.sol @@ -182,15 +182,15 @@ contract MSAAdvanced is IMSA, ExecutionHelper, ModuleManager, HookManager { returns (uint256 validSignature) { address validator; - // @notice validator encodig in nonce is just an example! + // @notice validator encoding in nonce is just an example! // @notice this is not part of the standard! - // Account Vendors may choose any other way to impolement validator selection + // Account Vendors may choose any other way to implement validator selection uint256 nonce = userOp.nonce; assembly { validator := shr(96, nonce) } - // check if validator is enabled. If terminate the validation phase. + // check if validator is enabled. If not terminate the validation phase. if (!_isValidatorInstalled(validator)) return VALIDATION_FAILED; // bubble up the return value of the validator module From 8158bef4ad887606f92964a3a3d3318af012ad42 Mon Sep 17 00:00:00 2001 From: Timur Badretdinov Date: Sat, 24 Feb 2024 14:56:48 +0000 Subject: [PATCH 4/4] fix: typo --- src/interfaces/IERC7579Account.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/interfaces/IERC7579Account.sol b/src/interfaces/IERC7579Account.sol index 89b97de..2c161a5 100644 --- a/src/interfaces/IERC7579Account.sol +++ b/src/interfaces/IERC7579Account.sol @@ -103,8 +103,8 @@ interface IERC7579Account { * @dev Implement Authorization control of your chosing * @param moduleType the module type ID according the ERC-7579 spec * @param module the module address - * @param deInitData arbitrary data that may be required on the module during `onInstall` - * initialization. + * @param deInitData arbitrary data that may be required on the module during `onUninstall` + * de-initialization. */ function uninstallModule( uint256 moduleType,