-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arguments for komodo-transpiler #308
Comments
Just a question because as mentioned in the stand-up, I find the language a bit confusing. ❓ Does the Release Manager want to maintain a single release matrix file, or multiple release files? I think it's the matrix file, is that correct? (I know right now that the matrix file and release file are "sort of" the same thing, although strictly speaking what is being maintained is a release file.) I see that
|
I had a thought about how to add the urgently needed capability to produce a single 'cell' in a release matrix, without having to hardcode 'redhat' and 'python' into the tool in yet another place. Maybe the interface could look like:
This Maybe What do you think @xjules and @hnformentin? Would this work? |
Thanks for the comments.
The point that @kwinkunks raised is valid, but let's treat it on another issue #316. |
Some changes to consider after discussion. (1) Base case:
(2) Should be supportable in the future:
(3) Use default values rhel=7 and py=3.8:
We discussed using nargs="*" and as far as I understood the = depends on design option. A requirement is to validate the input version within the |
I feel like we should not support option (3) unless we absolutely have to. For the mapping, I think it should be possible to make a CLI call like:
That's YAML formatting... could also use JSON formatting, but I think it needs more quotes, like You can do this sort of thing like:
The nice thing about this is you get a dictionary which has arbitrary keys and values, so you avoid having to pick it apart to get at everything, and it's a bit more future proof because I can pass in For this example the result is:
If you stick with Again, I definitely might be missing something about how exactly this needs to be called! |
I think the problem with passing
Would the following be the alternative proposed?
The problem with not having the default values is backwards compatibility. If we want to remove the default values, I think we should first have a deprecation warning and after sometime remove the default. |
I prefer the second pattern, if it gets the job done. I agree existing defaults should be deprecated (some time, not necessarily now), and only suggest not adding new defaults that specify architecture or other 'coordinates'. |
Thanks for persisting! That makes sense and, with @lars-petter-hauge, we found out that it is also possible to implement as a list.
where |
Currently
komodo-transpiler transpile
has hard-coded arguments for specifying python and rhel versions. We should be able to retrieve the versions from the cli arguments.For example:
komodo-transpiler transpile --matrix-file=releases/matrices/${{ inputs.target }}.yml --python-ver=3.8 --rhel-ver=7 --output releases
The text was updated successfully, but these errors were encountered: