This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Issue16 arbitrary attributes #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… root schema. Resolves ept#14
…on-avro-defined attributes
…type if that is what the value refers to
…ta types, complex JSON blobs, and simple objects (string, integer, etc)
…emove unnecessary example.avsc as example_with_messages is a more complete example
|
@ept -- Just curious if you're going to have a chance to review these two patches in the near future and release 0.40 of avrodoc? Thanks! |
|
I merged this (with a few tweaks). Thanks very much Micah, and sorry that it took me so long to get round to it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented some code to output the arbitrary annotations that are supported in avro idl. These get translated to new key/value pairs of properties on the avro schema. In order to detect them, all we need to do is look for any keys on the object that both avrodoc as well as avro do not generate for the various types of objects.
I also updated the example output to include annotations of the various types that are supported with this patch.
Resolves issue #16
NOTE: There is a commit (851cf99) that I didn't mean to include in this pull request -- this is the commit for the work in issue #14. I reverted that change in (13abdb2).
Let me know if you'd like me to clean this up a bit.
Thanks!
Micah