Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmark for LTS Node Version #143

Open
cjlludwig opened this issue Mar 21, 2024 · 2 comments
Open

Update Benchmark for LTS Node Version #143

cjlludwig opened this issue Mar 21, 2024 · 2 comments

Comments

@cjlludwig
Copy link

cjlludwig commented Mar 21, 2024

Definitely a nitpick but would love to see the README / benchmark logic updated to the LTS Node version!

https://nodejs.org/en/download

https://github.com/epoberezkin/fast-deep-equal/blob/master/README.md#performance-benchmark

@benasher44
Copy link

Performance improvements were made to isDeepStrictEqual as of node 18, so it would be great to see this updated https://github.com/nodejs/node/commits/main/lib/internal/util/comparisons.js

@electrovir
Copy link

electrovir commented Aug 13, 2024

I tried running benchmarks and they error out on Node.js v18, v20, and v22 with lots of "different result" errors and also "require() of ES Module not supported".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants