Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Store block extra data in a separate table #146

Merged
merged 3 commits into from
May 24, 2024
Merged

[1.0] Store block extra data in a separate table #146

merged 3 commits into from
May 24, 2024

Conversation

elmato
Copy link
Contributor

@elmato elmato commented May 21, 2024

No description provided.

@elmato elmato requested a review from yarkinwho May 21, 2024 05:14
@elmato elmato changed the title Store block extra data in a separate table [1.0] Store block extra data in a separate table May 21, 2024
@yarkinwho
Copy link
Contributor

Any special reason for using the height+hash as key to the extra data table?

@elmato
Copy link
Contributor Author

elmato commented May 22, 2024

Any special reason for using the height+hash as key to the extra data table?

No special reason, we just followed the BlockBody table schema approach because of the similarities between BlockBody and ExtraBlockData in terms that both belong to a Block.

BlockBody
//!   key   : block number (BE 8 bytes) + block header hash (32 bytes)
//!   value : block body data RLP encoded

@elmato elmato merged commit 6325c33 into release/1.0 May 24, 2024
5 checks passed
@elmato elmato deleted the elmato/fix-serialization-consensus-params branch May 24, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarkinwho yarkinwho yarkinwho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elmato @yarkinwho