Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the way we handle block rewards #107

Open
yarkinwho opened this issue Dec 8, 2023 · 3 comments
Open

Review the way we handle block rewards #107

yarkinwho opened this issue Dec 8, 2023 · 3 comments

Comments

@yarkinwho
Copy link
Contributor

As touched in #80 , the current logic is we will return 0 if the consensus engine is not ethash.

However, though we are not using it in our node, the clique case needs to be considered. It is not ethash but it might have block rewards.

@stephenpdeos
Copy link
Member

We want to change the logic to return 0 only when we are using our trust rule set

@yarkinwho
Copy link
Contributor Author

More findings:
Upstream silkworm has inconsistency in the APIs regarding to this issue as well. So we should keep the current way for now and contact upstream first.

@yarkinwho
Copy link
Contributor Author

Submitted erigontech/silkworm#1717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants