Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block invalid EOS Account characters from being entered within Destination Account field #36

Open
stephenpdeos opened this issue Aug 29, 2023 · 1 comment
Labels
enhancement New feature or request 👍 lgtm

Comments

@stephenpdeos
Copy link
Member

stephenpdeos commented Aug 29, 2023

Within the EVM Bridge Frontend, the Destination Account field for Withdrawal functions allows input of characters that fall outside the limited criteria for EOS Accounts of

  • Must contain exactly 12 characters from the base32 set: ., 1-5, a-z
  • Must not end in a dot . character

As a result, we should limit the Destination Account field to

  • Accept only the valid range of characters
  • Allow input of no more than 12 characters
  • Prevents inputting . as the 12th character
@stephenpdeos stephenpdeos changed the title Better field constraints in bridge Block invalid EOS Account characters from being entered within Destination Account field Aug 29, 2023
@stephenpdeos stephenpdeos added 👍 lgtm enhancement New feature or request labels Aug 29, 2023
@stephenpdeos stephenpdeos added this to the Bridge Frontend 0.9.0 milestone Sep 7, 2023
@stephenpdeos stephenpdeos removed this from the Bridge Frontend 0.9.0 milestone Sep 13, 2023
@yarkinwho
Copy link
Contributor

There's one corner case can cause trouble: what if I paste in a wrong address. If I block the input, this will significantly confuse user as he may think there's something wrong with the copy/paste mechanism (either blame the site or system).

We need a well designed interaction (such as an extra error message) to counter this case.

In addition, it might be more helpful for a user to identify the problem if the illegal character is shown. That's similar to why you need the display password feature in some cases.

For example, if ii copy a string from my console, if i am not careful enough, i will actually copy the color code as well. then when you paste you will get things like: ^[[200username.

It will be quite confusion why the pasted username cannot go through if i can not see what I actually pasted in.

Therefore, I think we need some careful design before we can push this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm
Projects
Status: Todo
Development

No branches or pull requests

2 participants