Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memo does not work with class components #2025

Closed
ljharb opened this issue Feb 26, 2019 · 2 comments
Closed

memo does not work with class components #2025

ljharb opened this issue Feb 26, 2019 · 2 comments
Labels
bug package: react adapter: 16

Comments

@ljharb
Copy link
Member

ljharb commented Feb 26, 2019

Followup from #1914 and #1875.

See #1914 (comment) and
6b3274b; once facebook/react#14807 (comment) is resolved, we'll need to revisit these tests.
@kachkaev
Copy link

kachkaev commented May 7, 2019

facebook/react#14807 seems to be closed now

@ljharb
Copy link
Member Author

ljharb commented May 8, 2019

hmnm, this already seems revisited here: https://github.com/airbnb/enzyme/blob/master/packages/enzyme-test-suite/test/shared/methods/find.jsx#L918 - but I suspect that's the cause of #2113. Closing in favor of that.

@ljharb ljharb closed this as completed May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug package: react adapter: 16
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @kachkaev