Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Load envoy_repo in the WORKSPACE #35758

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Aug 20, 2024

This is to fix this error.

ERROR: Skipping '@envoy//tools/code_format:check_format': error loading package '@envoy//tools/code_format': Unable to find package for @envoy_repo//:path.bzl: The repository '@envoy_repo' could not be resolved: Repository '@envoy_repo' is not defined.

Risk Level: low
Testing: tools/check_format.sh fix
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #35758 was opened by fredyw.

see: more, trace.

@fredyw fredyw marked this pull request as ready for review August 20, 2024 15:08
@fredyw
Copy link
Member Author

fredyw commented Aug 20, 2024

/assign @phlax

@fredyw fredyw enabled auto-merge (squash) August 20, 2024 15:16
@fredyw fredyw merged commit e77a708 into envoyproxy:main Aug 20, 2024
32 checks passed
@fredyw fredyw deleted the fix_mobile_format_ci branch August 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants