Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile/deps: Bump rules_detekt -> 0.8.1.2 #35417

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Jul 24, 2024

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jul 24, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @RyanTheOptimist

🐱

Caused by: #35417 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Jul 24, 2024

this is required to update rules_proto

fredyw
fredyw previously approved these changes Jul 24, 2024
Copy link
Member

@fredyw fredyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phlax phlax enabled auto-merge (squash) July 24, 2024 17:21
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@fredyw
Copy link
Member

fredyw commented Jul 25, 2024

A temporary fix #35345 was merged. Please rebase.

@RyanTheOptimist
Copy link
Contributor

/retest

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 25, 2024
@phlax phlax disabled auto-merge July 25, 2024 17:54
@phlax phlax merged commit ca939ee into envoyproxy:main Jul 25, 2024
34 of 35 checks passed
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants