Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: Add no-remote-exec in the Swift tests #35345

Merged
merged 1 commit into from
Jul 25, 2024
Merged

mobile: Add no-remote-exec in the Swift tests #35345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mobile/test/swift/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ envoy_mobile_swift_test(
"RetryPolicyMapperTests.swift",
"RetryPolicyTests.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
flaky = True, # TODO(jpsim): Fix timeouts when running these tests on CI
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
"//library/objective-c:envoy_engine_objc_lib",
Expand Down
170 changes: 119 additions & 51 deletions mobile/test/swift/integration/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ envoy_mobile_swift_test(
srcs = [
"EndToEndNetworkingTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -26,9 +30,13 @@ envoy_mobile_swift_test(
srcs = [
"CancelStreamTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -42,9 +50,13 @@ envoy_mobile_swift_test(
srcs = [
"EngineApiTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -57,9 +69,13 @@ envoy_mobile_swift_test(
srcs = [
"FilterResetIdleTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -73,9 +89,13 @@ envoy_mobile_swift_test(
srcs = [
"GRPCReceiveErrorTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -89,9 +109,13 @@ envoy_mobile_swift_test(
srcs = [
"IdleTimeoutTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -105,9 +129,13 @@ envoy_mobile_swift_test(
srcs = [
"KeyValueStoreTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -121,9 +149,13 @@ envoy_mobile_swift_test(
srcs = [
"ReceiveDataTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -137,9 +169,13 @@ envoy_mobile_swift_test(
srcs = [
"ReceiveErrorTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -152,9 +188,13 @@ envoy_mobile_swift_test(
srcs = [
"ResetConnectivityStateTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -168,9 +208,13 @@ envoy_mobile_swift_test(
srcs = [
"SendDataTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -184,9 +228,13 @@ envoy_mobile_swift_test(
srcs = [
"SendHeadersTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -200,9 +248,13 @@ envoy_mobile_swift_test(
srcs = [
"SendTrailersTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -216,9 +268,13 @@ envoy_mobile_swift_test(
srcs = [
"SetEventTrackerTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -232,9 +288,13 @@ envoy_mobile_swift_test(
srcs = [
"SetEventTrackerTestNoTracker.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -248,9 +308,13 @@ envoy_mobile_swift_test(
srcs = [
"SetLoggerTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand All @@ -264,9 +328,13 @@ envoy_mobile_swift_test(
srcs = [
"CancelGRPCStreamTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
":test_extensions",
Expand Down
10 changes: 7 additions & 3 deletions mobile/test/swift/integration/proxying/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@ envoy_mobile_swift_test(
srcs = [
"HTTPRequestUsingProxyTest.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# TODO(fredyw): Re-enable remote-exec.
# exec_properties = {
# "sandboxNetwork": "standard",
# },
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
"//library/objective-c:envoy_engine_objc_lib",
Expand Down
9 changes: 6 additions & 3 deletions mobile/test/swift/stats/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@ envoy_mobile_swift_test(
"ElementTests.swift",
"TagsBuilderTests.swift",
],
exec_properties = {
"sandboxNetwork": "standard",
},
# exec_properties = {
# "sandboxNetwork": "standard",
# },
flaky = True, # TODO(jpsim): Fix timeouts when running these tests on CI
tags = [
"no-remote-exec",
],
visibility = ["//visibility:public"],
deps = [
"//library/objective-c:envoy_engine_objc_lib",
Expand Down