Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Add no-remote-exec in the Swift tests #35345

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Jul 22, 2024

A temporary fix for #35316.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #35345 was opened by fredyw.

see: more, trace.

@fredyw fredyw force-pushed the ios_tests_flaky branch 2 times, most recently from 305e1fb to d601479 Compare July 22, 2024 21:52
@fredyw fredyw changed the title Test [Testing] Add no-remote-exec Jul 22, 2024
@fredyw fredyw changed the title [Testing] Add no-remote-exec [Testing] Add no-remote-exec in the Swift tests Jul 22, 2024
@fredyw fredyw changed the title [Testing] Add no-remote-exec in the Swift tests mobile: Add no-remote-exec in the Swift tests Jul 24, 2024
@fredyw
Copy link
Member Author

fredyw commented Jul 24, 2024

/retest

@fredyw fredyw marked this pull request as ready for review July 24, 2024 19:59
@fredyw
Copy link
Member Author

fredyw commented Jul 24, 2024

/assign @alyssawilk

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks so much

@fredyw fredyw merged commit 88374d7 into envoyproxy:main Jul 25, 2024
33 checks passed
@fredyw fredyw deleted the ios_tests_flaky branch July 25, 2024 12:51
fredyw added a commit to fredyw/envoy that referenced this pull request Jul 25, 2024
fredyw added a commit to fredyw/envoy that referenced this pull request Jul 26, 2024
fredyw added a commit to fredyw/envoy that referenced this pull request Jul 26, 2024
phlax pushed a commit that referenced this pull request Jul 26, 2024
This reverts commit 88374d7.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
A temporary fix for envoyproxy#35316.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
…)" (envoyproxy#35438)

This reverts commit 88374d7.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Martin Duke <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
A temporary fix for envoyproxy#35316.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: asingh-g <[email protected]>
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
…)" (envoyproxy#35438)

This reverts commit 88374d7.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: asingh-g <[email protected]>
phlax pushed a commit to phlax/envoy that referenced this pull request Sep 9, 2024
…5345)

A temporary fix for envoyproxy#35316.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants