Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimisation: Replacing listView in CarSelectionActivity with Recycler View #968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimisation: Replacing listView in CarSelectionActivity with Recycler View #968

wants to merge 1 commit into from

Conversation

Jdbarad
Copy link
Contributor

@Jdbarad Jdbarad commented Nov 30, 2022

204805667-c032eb10-a863-45fe-80af-3400efa1e2e0.mp4

@Jdbarad
Copy link
Contributor Author

Jdbarad commented Dec 1, 2022 •
edited
Loading

Description

This activity presently contains listView for showing the list of cars which is not an efficient approach.
This listView needs to be replaced with RecyclerView having well-designed CardViews which will lead to a better user interface as well as better app performance.

How did it get fixed?

Replace ListView with RecyclerView, Create CarSelectionRecyclerAdapter for mCarRecyclerView
Create a function & method that is also required in CarSelectionListAdapter. Also added CardView for a better user experience.

Conclusion

Now, CarSelectionActivity uses RecyclerView, That better for App performance. Also Solved Broken car selection radio button #927

Reviews

I like to invite @SebaDro Sir & @asaikarthikeya sir to review this PR and give me suggestions

@Jdbarad
Copy link
Contributor Author

Jdbarad commented Dec 24, 2022

@SebaDro Sir Please Review this PR

@SebaDro SebaDro self-assigned this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SebaDro SebaDro

Labels
1 - Ready enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jdbarad @SebaDro