Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting t from n validators for threshold signing #899

Closed
ameba23 opened this issue Jun 20, 2024 · 1 comment · Fixed by #1050
Closed

Selecting t from n validators for threshold signing #899

ameba23 opened this issue Jun 20, 2024 · 1 comment · Fixed by #1050
Assignees
Labels
Fix something that's not working as intended

Comments

@ameba23
Copy link
Contributor

ameba23 commented Jun 20, 2024

Currently in the Migrate-to-threshold branch we select t from n validators to sign a message deterministically by sorting the list of validators and taking the first t elements.

This is not good because it means we always select the same ones.

We need another way to do this. One suggestion is to go back to using message hash. But there were also concerns about rate limiting / DoS when using message hash.

See also #859

@HCastano HCastano added the Fix something that's not working as intended label Jun 24, 2024
@HCastano HCastano added this to the t-of-N Redesign milestone Jun 24, 2024
@HCastano HCastano self-assigned this Sep 9, 2024
@HCastano
Copy link
Collaborator

HCastano commented Sep 9, 2024

If we tie this into the message passing issue (#1033) we may be able to get away with just having the relayer pick some random subset using OS randomness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix something that's not working as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants