Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to change number of subgroups on running network #656

Closed
HCastano opened this issue Mar 1, 2024 · 2 comments
Closed

Add way to change number of subgroups on running network #656

HCastano opened this issue Mar 1, 2024 · 2 comments

Comments

@HCastano
Copy link
Collaborator

HCastano commented Mar 1, 2024

Right now we need to specify the number of subgroups we want as part of genesis. If later on in the life of the network we decide that we want to change this number, for example to increase it as the size of the validator set increases, there is no way for us to do this without restarting the network.

A couple of tricky things here:

  1. How we would re-key all the validators. Put another way, how would we migrate the existing keyshares that validators have into the new set of subgroups?

We may be able to get away with doing some of the work in session N-1, and only applying the subgroup change in session N.

  1. How do we migrate keyshares of users with a private access mode

It's not reasonable to expect users to come online at some arbitrary session to re-key, so how would we get them to migrate?

@ameba23
Copy link
Contributor

ameba23 commented Mar 5, 2024

Now that we have a version number associated with each user (#658), this is much easier as we can increase the number of subgroups for new users without needing to migrate existing users. Although decreasing it would be pretty complicated.

Having said that, as i have said elsewhere i think increasing the number of subgroups is not a good solution to the problem of increased keyshare redundancy as the network grows. I think our subgroup system needs rethinking.

@HCastano HCastano added this to the t-of-N Redesign milestone May 21, 2024
@HCastano
Copy link
Collaborator Author

HCastano commented Sep 9, 2024

We don't have subgroups anymore.

@HCastano HCastano closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants