Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate slow Registry benchmarks #480

Closed
HCastano opened this issue Nov 7, 2023 · 1 comment
Closed

Investigate slow Registry benchmarks #480

HCastano opened this issue Nov 7, 2023 · 1 comment
Labels
Fix something that's not working as intended

Comments

@HCastano
Copy link
Collaborator

HCastano commented Nov 7, 2023

The Relayer pallet runtime benchmarks can be quite slow to run, especially if not built
in release mode.

I'm convinced that it has to do with the benchmark setup process being done in polynomial
time (nested for-loops when calling add_non_syncing_validators).

for i in 0..SIG_PARTIES {
    let validators = add_non_syncing_validators::<T>(sig_party_size, 0, i as u8);
    <ThresholdToStash<T>>::insert(&threshold_account, &validators[i]);
}

We should look into whether or not there's a way to set the benchmarks up in a more
efficient manner.

@HCastano HCastano added the Fix something that's not working as intended label Nov 7, 2023
@HCastano HCastano changed the title Investigate slow Relayer benchmarks Investigate slow Registry benchmarks Sep 9, 2024
@HCastano
Copy link
Collaborator Author

HCastano commented Sep 9, 2024

Closing, I don't think anybody has time to look into it. Not a huge issue since we're only running this on releases.

@HCastano HCastano closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix something that's not working as intended
Projects
Status: Done
Development

No branches or pull requests

1 participant