Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use sig_hash for select signing subgroup #392

Closed
jakehemmerle opened this issue Sep 4, 2023 · 2 comments
Closed

Don't use sig_hash for select signing subgroup #392

jakehemmerle opened this issue Sep 4, 2023 · 2 comments

Comments

@jakehemmerle
Copy link
Contributor

Using the message-to-be-signed hash as the source of entropy to use for randomly selecting a signing group is unsafe, as a user can intentionally overwhelm a specific subset of validators.

@ameba23
Copy link
Contributor

ameba23 commented Sep 7, 2023

Would it be an improvement if we used create_unique_tx_id - meaning both the signature request id and the message hash?

I'm not sure it really helps as essentially the user can still try a bunch of messages until they get particular validators.

For registering, we use the current block number to choose validators for DKG, which you could also argue allows an attack like this, although you only get so much time to send requests.

We could also include that here, (eg: message hash + block number + account id), but then you get into problems when a request is sent just as a block is published.

I think the simplest solution would be that sign_tx responds with an error when we already have a certain number of pending Listeners from this signature request account (by checking keys of ListenerState).

@HCastano
Copy link
Collaborator

HCastano commented Sep 9, 2024

This is going to be dealt with was part of the message passing flow in #1033.

@HCastano HCastano closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants