Fix an overzealous test #1749
Merged
Fix an overzealous test #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
approved these changes
Jun 26, 2023
|
Looks good. |
Closed
mdickinson
added a commit
that referenced
this pull request
Jul 10, 2023
This PR fixes one part of the cause of #1748, namely that a test was failing on warnings that were unrelated to the test purpose.
Closed
mdickinson
added a commit
that referenced
this pull request
Jul 26, 2023
mdickinson
added a commit
that referenced
this pull request
Jul 26, 2023
mdickinson
added a commit
that referenced
this pull request
Aug 7, 2023
This PR (against the maint/6.4 branch) is aimed at a 6.4.2 bugfix release. Key changes: - Backport PR #1746 - Backport PR #1749 - Update copyright headers and bring CI back to working state - Update changelog, bump version for release. The PR is pretty horrendous to review en masse thanks to the changelog updates, but it should be possible to review it commit by commit. @corranwebster Would you have bandwidth for review at some point? (Feel free to unassign if not.) --------- Co-authored-by: homosapien-lcy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one part of the cause of #1748, namely that a test was failing on warnings that were unrelated to the test purpose.