-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate compatibility with Python 3.11 #163
Comments
The test is added to PR #168. I only added python 3.11 for the pypi test since the 3.6 version will give "The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04." error |
@homosapien-lcy Thank you! Next steps are:
|
Note: this will require some reworking of the workflow to use a version of Python provided by GitHub Actions (via the Some other ETS packages already have such a workflow: examples are |
Sure, will look into it |
@mdickinson Is it something like this in test-with-edm.yml? (just 3.11 instead?) (image from envisage) |
@homosapien-lcy Yes, something along those lines. By the way, it's not good practice to post screenshots of code - it obstructs search, and can make it difficult to follow what's going on on some devices. In this case, you can link to the relevant code instead. (See the GitHub documentation for how to do that if you need to.) |
@homosapien-lcy Actually, what we're looking for is something more like this: https://github.com/enthought/envisage/blob/main/.github/workflows/test-with-pypi.yml Note that in this workflow, we're not using EDM at all: we're testing directly using the GitHub Actions-provided Python versions. It would be great if you could put something together along these lines. |
@homosapien-lcy Just a reminder from above:
|
With new python update, we create this PR to test whether the scimath package is compatible with python 3.11. Closes #163 --------- Co-authored-by: Chengyu Liu <[email protected]>
@homosapien-lcy Thanks for opening #170. I think it's fine to not support Python 3.6 for the new workflow. |
I've opened #171 for this. |
@homosapien-lcy The discussion gets a bit confusing when you make substantial edits to a previous comment, as with #163 (comment). In the original comment, you mentioned some unexpected test output, but the edited comment removes all mention of that, which makes the subsequent discussion a bit hard to follow. If there's new information, I'd recommend making a new comment with that new information instead. |
Thanks for the advice Marks! In the future I will avoid too much editting... Also, I found there might be an easy fix for issue #171, I mentioned that in the issue, do you want to take a look? |
We need to check whether scimath is compatible with Python 3.11:
If all looks good on Python 3.11, it would be great to have a GitHub Actions workflow that runs the scimath test suite under Python 3.11. If not, we need to open issues and fixes for whatever turns up.
The text was updated successfully, but these errors were encountered: