Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate compatibility with Python 3.11 #163

Closed
mdickinson opened this issue Mar 3, 2023 · 13 comments · Fixed by #168
Closed

Investigate compatibility with Python 3.11 #163

mdickinson opened this issue Mar 3, 2023 · 13 comments · Fixed by #168
Assignees

Comments

@mdickinson
Copy link
Member

We need to check whether scimath is compatible with Python 3.11:

  • Create a Python 3.11 venv
  • Install scimath into it (try both from a recent GitHub clone, and from PyPI)
  • Run the test suite

If all looks good on Python 3.11, it would be great to have a GitHub Actions workflow that runs the scimath test suite under Python 3.11. If not, we need to open issues and fixes for whatever turns up.

@homosapien-lcy
Copy link
Contributor

homosapien-lcy commented Mar 6, 2023

The test is added to PR #168. I only added python 3.11 for the pypi test since the 3.6 version will give "The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04." error

@homosapien-lcy homosapien-lcy self-assigned this Mar 6, 2023
@mdickinson
Copy link
Member Author

@homosapien-lcy Thank you! Next steps are:

  • Extend the GitHub Actions workflow to test on Python 3.11 as well as Python 3.6 and Python 3.8.
  • Please could you open an issue for the unexpected test output? I agree that it looks as though it's intended, but we should be able to find a way to silence the output in the test itself. Ideally we'd have a clean test run.

@mdickinson
Copy link
Member Author

  • Extend the GitHub Actions workflow to test on Python 3.11 as well as Python 3.6 and Python 3.8.

Note: this will require some reworking of the workflow to use a version of Python provided by GitHub Actions (via the setup-python action) instead of from EDM. It might be cleanest to create a new workflow that runs the SciMath test suite outside of the context of EDM, and doesn't use EDM at all.

Some other ETS packages already have such a workflow: examples are apptools, envisage and traits.

@homosapien-lcy
Copy link
Contributor

Sure, will look into it

@homosapien-lcy
Copy link
Contributor

homosapien-lcy commented Mar 15, 2023

@mdickinson Is it something like this in test-with-edm.yml? (just 3.11 instead?) Screen Shot 2023-03-15 at 6.03.43 PM.png (image from envisage)

@mdickinson
Copy link
Member Author

@homosapien-lcy Yes, something along those lines.

By the way, it's not good practice to post screenshots of code - it obstructs search, and can make it difficult to follow what's going on on some devices. In this case, you can link to the relevant code instead. (See the GitHub documentation for how to do that if you need to.)

@mdickinson
Copy link
Member Author

@homosapien-lcy Actually, what we're looking for is something more like this: https://github.com/enthought/envisage/blob/main/.github/workflows/test-with-pypi.yml

Note that in this workflow, we're not using EDM at all: we're testing directly using the GitHub Actions-provided Python versions. It would be great if you could put something together along these lines.

@mdickinson
Copy link
Member Author

@homosapien-lcy Just a reminder from above:

Please could you open an issue for the unexpected test output?

@homosapien-lcy
Copy link
Contributor

The version '3.6' with architecture 'x64' was not found for Ubuntu 22.04."

Thanks, I just added it to issue #170. I also opened a PR #169 to demonstrate the error. Is this a good way to show the unexpected behavior?

mdickinson pushed a commit that referenced this issue Mar 17, 2023
With new python update, we create this PR to test whether the scimath
package is compatible with python 3.11.

Closes #163

---------

Co-authored-by: Chengyu Liu <[email protected]>
@mdickinson
Copy link
Member Author

@homosapien-lcy Thanks for opening #170. I think it's fine to not support Python 3.6 for the new workflow.

@mdickinson
Copy link
Member Author

@homosapien-lcy Just a reminder from above:

Please could you open an issue for the unexpected test output?

I've opened #171 for this.

@mdickinson
Copy link
Member Author

mdickinson commented Mar 17, 2023

@homosapien-lcy The discussion gets a bit confusing when you make substantial edits to a previous comment, as with #163 (comment). In the original comment, you mentioned some unexpected test output, but the edited comment removes all mention of that, which makes the subsequent discussion a bit hard to follow. If there's new information, I'd recommend making a new comment with that new information instead.

@homosapien-lcy
Copy link
Contributor

Thanks for the advice Marks! In the future I will avoid too much editting... Also, I found there might be an easy fix for issue #171, I mentioned that in the issue, do you want to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants