Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the behavior of == for upstream version match #108

Closed
cournape opened this issue Jan 1, 2016 · 4 comments
Closed

Fix the behavior of == for upstream version match #108

cournape opened this issue Jan 1, 2016 · 4 comments
Milestone
0.2

Comments

@cournape
Copy link
Contributor

cournape commented Jan 1, 2016

~= has a different meaning in PEP 440, so we should use a different syntax to avoid clashes. I would suggest something like ^= or #=.

We should also change == to be consistent w/ PEP 440.
See alo PEP 508
@cournape cournape added this to the 0.2 milestone Jan 1, 2016
@johntyree johntyree mentioned this issue Jan 13, 2016
Merged
@cournape
Copy link
Contributor Author

Fixed in #115

@johntyree
Copy link
Contributor

We haven't fixed the behaviour of == yet, if that's necessary.
On Jan 15, 2016 01:30, "David Cournapeau" [email protected] wrote:

Fixed in #115 #115

—
Reply to this email directly or view it on GitHub
#108 (comment)
.

@cournape
Copy link
Contributor Author

Indeed, we should fix that as well

@cournape cournape reopened this Jan 15, 2016
@johntyree johntyree changed the title Don't use ~= for upstream version match Fix the behavior of == for upstream version match Feb 21, 2016
@cournape
Copy link
Contributor Author

cournape commented Apr 1, 2016

Tracked more generally in #174

@cournape cournape closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@cournape @johntyree