86 - Additional additions for Edge CLI support #87
Conversation
There was a problem hiding this comment.
@EdwinWiseOne looks good to me except the comment regarding the repository and image_name.
Minimal/app_config.yaml
Outdated
| app_id: null | ||
| app_version: 1.2.0 | ||
| python_version: 3.8 | ||
| repository: quay.io/enthought |
There was a problem hiding this comment.
technically speaking this is the repository but part of the URI to the repo. Should be keep the repository server as quay.io and have the image_name being enthought/edge-minimal-example ? That is more in line with how images are typically described out there.
There was a problem hiding this comment.
Ahh yeah, that split makes sense
There was a problem hiding this comment.
Technically we have three parts: the server "quay.io", the repository "enthought", and the image name "edge-minimal-example" -- with the "enthought" and "edge-minimal-example" combined for a full repository name (in our current quay.io use). It might make sense to specify it in three parts instead of two.
There was a problem hiding this comment.
We can surely do three parts. The enthought part is the organisation(both on dockerhub and quay). The image name and the repository are the same.
Changes required by updates in the Edge CLI