Improve patching classes in _compointer_meta.
#624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `_cominterface_meta.__new__` into a `staticmethod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with #618, I noticed that
_cominterface_meta.__new__has quite a large number of lines.Most of these lines come from patching multiple classes with
patcher.Patch, so I refactored them into a separate method to reduce the number of lines in__new__itself.I considered that it could cause confusion if the separated method were an instance method with
selfas the first argument, as theselfof the class's instance methods which are defined inside the method, could get mixed up.Therefore, I defined the refactored method as a private
staticmethod.