Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_persist. #609

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Add test_persist. #609

merged 1 commit into from
Aug 31, 2024

Conversation

junkmd
Copy link
Collaborator

@junkmd junkmd commented Aug 31, 2024

The persist module has not been tested until now.

First, I added unit tests for IPersist, which serves as the base for the interfaces defined in the persist module.

Next, I added test cases for IPersistFile. It was easy to write them since its use cases are documented in shelllink.
To test IPersistFile::IsDirty, methods implemented in interfaces other than IPersistFile need to be called. These are already covered in the shelllink tests, so they are not included here.

I have not included tests for other interfaces, as their use cases are not yet clear.
I hope that tests for these interfaces will be expanded in the future with the community’s help.

@junkmd junkmd added the tests enhance or fix tests label Aug 31, 2024
@junkmd junkmd added this to the 1.4.7 milestone Aug 31, 2024
@junkmd junkmd merged commit 470bc09 into enthought:main Aug 31, 2024
49 checks passed
@junkmd junkmd deleted the test_persist branch August 31, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests enhance or fix tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant