Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_DISPPARAMS.TestCase.test. #660

Open
junkmd opened this issue Nov 10, 2024 · 0 comments
Open

Fix test_DISPPARAMS.TestCase.test. #660

junkmd opened this issue Nov 10, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@junkmd
Copy link
Collaborator

junkmd commented Nov 10, 2024

I think the following commented-out section might now succeed in its assertion.
If this test were to fail, tests for IDispatch.Invoke or dispatch methods would also fail as a result.

dp.rgvarg[1].value = "spam"
dp.rgvarg[2].value = "foo"
# damn, there's still this old bug!
self.assertEqual(dp.rgvarg[0].value, 42)
# these fail:
# self.failUnlessEqual(dp.rgvarg[1].value, "spam")
# self.failUnlessEqual(dp.rgvarg[2].value, "foo")
def X_test_2(self):
# basically the same test as above

@@ -15,12 +15,9 @@ class TestCase(ut.TestCase):
         dp.rgvarg[1].value = "spam"
         dp.rgvarg[2].value = "foo"

-        # damn, there's still this old bug!
-
         self.assertEqual(dp.rgvarg[0].value, 42)
-        # these fail:
-        # self.failUnlessEqual(dp.rgvarg[1].value, "spam")
-        # self.failUnlessEqual(dp.rgvarg[2].value, "foo")
+        self.assertEqual(dp.rgvarg[1].value, "spam")
+        self.assertEqual(dp.rgvarg[2].value, "foo")

     def X_test_2(self):
         # basically the same test as above
@junkmd junkmd added the good first issue Good for newcomers label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant