Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make select tool react on mouse up rather than mouse down. #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

corranwebster
Copy link
Contributor

This is a more natural user interaction, and allows the selection tool to co-exist with other tools (eg. PanTool2) in a nicer fashion.

@cfarrow
Copy link
Contributor

cfarrow commented Jun 10, 2014

I agree with the change, but I think it should be done in a backwards-compatible way. This change will cause all subclasses of SelectTool that overload normal_left_down to react on mouse down and mouse up. I recommend adding a flag that allows one to modify the selection behavior, and which defaults to the left-down behavior.

@itziakos
Copy link
Member

I would also like to note that activating the Tool at mouse_up without marking the position of the mouse_down can cause unexpected behaviour since the mouse_down -> mouse_up can take place far apart from each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants