Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBoxOverlay incorrectly overrides Component.padding #820

Open
corranwebster opened this issue Oct 21, 2021 · 0 comments
Open

TextBoxOverlay incorrectly overrides Component.padding #820

corranwebster opened this issue Oct 21, 2021 · 0 comments
Milestone

Comments

@corranwebster
Copy link
Contributor

Problem Description

The base Component class has a padding trait which is a Property that can take a number of different values, but TextBoxOverlay which is a subclass of Component, overrides this as an Int.

This is used as a margin around all sides of the text inside the component's rectangle, rather than the padding outside the rectangle.

A simple fix would be to re-name the trait on TextBoxOverlay to something else (eg. text_padding or margin).

@corranwebster corranwebster added this to the Release 5.1.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant