Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore and Delete dialogs should inherit from DependantItemsWithProgressDialog #308

Open
alansemenov opened this issue Nov 24, 2021 · 0 comments
Open

Restore and Delete dialogs should inherit from DependantItemsWithProgressDialog #308

alansemenov opened this issue Nov 24, 2021 · 0 comments
Labels
Improvement New feature or request

Comments

@alansemenov
Copy link
Member

ArchiveRestoreDialog and ArchiveDeleteDialog dialogs are derived from ModalDialog (via ArchiveDialog). As a result, there's custom implementation of progress bar in the former and no progress bar at all in the latter. We should fix it so that both are deriving from DependantItemsWithProgressDialog (ideally, ArchiveDeleteDialog should derive from ContentDeleteDialog as they are supposed to look and act exactly the same except for using different endpoints and small differences in texts.
@alansemenov alansemenov added the Improvement New feature or request label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alansemenov