New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher removes all icons from some apps because css classes are not namespaced #108

Open

ComLock opened this issue Jun 17, 2020 · 0 comments

Assignees

Labels

Bug

Member

ComLock commented Jun 17, 2020

When adding launcher/bundle.js which includes launcher.css to app-explorer all icons disappear.

This happens because launcher.css uses a really common class name: .icon

I think this is where the problem is:
https://github.com/enonic/app-admin-home/blob/master/src/main/resources/assets/icons/icons.less#L11

The reason it affects app-explorer is that app-explorer uses semantic-ui which also declares .icon

ComLock assigned alansemenov

alansemenov added the Bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment