Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure no_std mode works #59

Open
bstrie opened this issue Oct 12, 2022 · 2 comments
Open

Make sure no_std mode works #59

bstrie opened this issue Oct 12, 2022 · 2 comments

Comments

@bstrie
Copy link
Contributor

bstrie commented Oct 12, 2022

Investigation as a part of #54 seems to suggest that ciborium links, if not to libstd, then at least to liballoc, regardless of the presence of the std feature flag. I'm unsure whether or not this is intentional; I assume that disabling the std flag in this crate is intended to disable both liballoc and libstd. I'm unsure when this regression happened (if indeed this is a regression at all), but we should see about fixing it before issuing the next release. We may also want to consider adding an alloc feature.

@chrysn
Copy link

chrysn commented Dec 1, 2022

Just one data point: I'm using ciborium through the dcaf and coset libraries without pulling in std; I'm building for thumbv7em-none-eabihf which has no std built.

Nonetheless, testing that this property is upheld is quite valuable. Something similar was done in wasmi-labs/wasmi#387, which might be useful as a template.

@ahmedcharles
Copy link
Contributor

The ciborium crate requires alloc, so adding a feature would require changing it to not require alloc. The ciborium-io and ciborium-ll crates already have an alloc feature which seems to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

3 participants